Re: Stefan's bug (was: max_standby_delay considered harmful) - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Stefan's bug (was: max_standby_delay considered harmful)
Date
Msg-id AANLkTikdSNUOYpYcs6FPLUApUCT-cg2H5P1BiK9G-Jsw@mail.gmail.com
Whole thread Raw
In response to Re: Stefan's bug (was: max_standby_delay considered harmful)  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Stefan's bug (was: max_standby_delay considered harmful)
Re: Stefan's bug (was: max_standby_delay considered harmful)
Re: Stefan's bug (was: max_standby_delay considered harmful)
List pgsql-hackers
On Mon, May 24, 2010 at 10:26 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> This looks pretty reasonable to me, but I guess I feel like it would
> be better to drive the CancelBackup() decision off of whether we've
> ever reached PM_RUN rather than consulting XLogCtl.  It just feels
> cleaner to me to drive all of the postmaster decisions off of the same
> signalling mechanism rather than having a separate one (that only
> works because it's used very late in shutdown when we theoretically
> don't need a lock) just for this one case.

Okay, how about the attached patch? It uses the postmaster-local flag
"ReachedEndOfRecovery" (better name?) instead of XLogCtl one.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center

Attachment

pgsql-hackers by date:

Previous
From: "Greg Sabino Mullane"
Date:
Subject: Re: Specification for Trusted PLs?
Next
From: Robert Haas
Date:
Subject: Re: Stefan's bug (was: max_standby_delay considered harmful)