Re: ask for review of MERGE - Mailing list pgsql-hackers

From Robert Haas
Subject Re: ask for review of MERGE
Date
Msg-id AANLkTikpirN5GxpSgDwj=M4rv=oaq2n-iv1awXCQDYA6@mail.gmail.com
Whole thread Raw
In response to Re: ask for review of MERGE  (Greg Smith <greg@2ndquadrant.com>)
Responses Re: ask for review of MERGE
List pgsql-hackers
On Wed, Sep 29, 2010 at 2:44 AM, Greg Smith <greg@2ndquadrant.com> wrote:
> One compiler warning I noticed that needs to get resolved:
>
> src/backend/commands/explain.c:
>
> explain.c: In function ‘ExplainMergeActions’:
> explain.c:1528: warning: comparison of distinct pointer types lacks a cast
>
> That is complaining about this section:
>
> if (mt_planstate->operation != CMD_MERGE ||
> mt_planstate->mt_mergeActPstates == NIL)
> return;
>
> So presumably that comparison with NIL needs a cast. Once I get more
> familiar with the code I'll fix that myself if Boxuan doesn't offer a
> suggestion first.

Possibly NULL was meant instead of NIL.  NIL is specifically for a List.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: I: About "Our CLUSTER implementation is pessimal" patch
Next
From: Boxuan Zhai
Date:
Subject: Re: ask for review of MERGE