> One compiler warning I noticed that needs to get resolved: > > src/backend/commands/explain.c: > > explain.c: In function ‘ExplainMergeActions’: > explain.c:1528: warning: comparison of distinct pointer types lacks a cast > > That is complaining about this section: > > if (mt_planstate->operation != CMD_MERGE || > mt_planstate->mt_mergeActPstates == NIL) > return; > > So presumably that comparison with NIL needs a cast. Once I get more > familiar with the code I'll fix that myself if Boxuan doesn't offer a > suggestion first.
Possibly NULL was meant instead of NIL. NIL is specifically for a List.
Yes, it should be NULL instead of NIL.
At first, I designed this filed as a List. But I changed it into an array in the last editions. This is why I have an unmatched assignment here. Sorry for that.