On Thu, Nov 25, 2010 at 11:23 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> No, what I was suggesting was taking the existing function:
>> extern void pgstat_report_waiting(bool waiting);
>> ...and instead doing something like this:
>> extern void pgstat_report_waiting(char *reason);
>> ...and then arrange to pass the reason via the eponymous argument.
>
> The question is how many cycles are we willing to expend on preparing a
> reason string that (in approximately 99.9% of the calls) will not be
> of any use. It would be much better to avoid doing this and instead
> expend the extra work on the inspection side.
I'd much rather have the information be pulled than pushed, if there's
a way to make that work.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
