Re: Add ENCODING option to COPY - Mailing list pgsql-hackers

From Hitoshi Harada
Subject Re: Add ENCODING option to COPY
Date
Msg-id AANLkTik8tix7bXC+vytgSpaHXESe6rn3LWngfJow7mkq@mail.gmail.com
Whole thread Raw
In response to Re: Add ENCODING option to COPY  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Add ENCODING option to COPY  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
2011/2/5 Tom Lane <tgl@sss.pgh.pa.us>:
> Hitoshi Harada <umi.tanuki@gmail.com> writes:
>> 2011/2/5 Tom Lane <tgl@sss.pgh.pa.us>:
>>> Yeah, putting backend-only stuff into that header is a nonstarter.
>
>> Do you mean you think it' all right to define
>> pg_cached_encoding_conversion() in pg_conversion_fn.h?
>
> That seems pretty random too.  I still think you've designed this API
> badly and it'd be better to avoid exposing the FmgrInfo to callers
> by letting the function manage the cache internally.

I'll try it in a few days, but only making struct that holds FmgrInfo
in a file local like tuplestorestate comes up with so far....

Regards,

--
Hitoshi Harada


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Extensions support for pg_dump, patch v27
Next
From: Greg Smith
Date:
Subject: Re: Spread checkpoint sync