Re: Add ENCODING option to COPY - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Add ENCODING option to COPY
Date
Msg-id 24297.1296838324@sss.pgh.pa.us
Whole thread Raw
In response to Re: Add ENCODING option to COPY  (Hitoshi Harada <umi.tanuki@gmail.com>)
Responses Re: Add ENCODING option to COPY  (Hitoshi Harada <umi.tanuki@gmail.com>)
List pgsql-hackers
Hitoshi Harada <umi.tanuki@gmail.com> writes:
> 2011/2/5 Tom Lane <tgl@sss.pgh.pa.us>:
>> Yeah, putting backend-only stuff into that header is a nonstarter.

> Do you mean you think it' all right to define
> pg_cached_encoding_conversion() in pg_conversion_fn.h?

That seems pretty random too.  I still think you've designed this API
badly and it'd be better to avoid exposing the FmgrInfo to callers
by letting the function manage the cache internally.
        regards, tom lane


pgsql-hackers by date:

Previous
From: "David E. Wheeler"
Date:
Subject: Re: ALTER EXTENSION UPGRADE, v3
Next
From: Robert Haas
Date:
Subject: Re: ALTER EXTENSION UPGRADE, v3