Re: why does plperl cache functions using just a bool for is_trigger - Mailing list pgsql-hackers

From Alex Hunsaker
Subject Re: why does plperl cache functions using just a bool for is_trigger
Date
Msg-id AANLkTi=BK6FGvLRpMrC1uZw8hTFACKzn1hgTDGUs_Vr3@mail.gmail.com
Whole thread Raw
In response to Re: why does plperl cache functions using just a bool for is_trigger  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: why does plperl cache functions using just a bool for is_trigger
List pgsql-hackers
On Mon, Nov 1, 2010 at 16:59, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Alex Hunsaker <badalex@gmail.com> writes:
>> Speaking of which, pltcl stores the trigger reloid instead of a flag
>> (it also uses tg_reloid in the internal proname).  It seems a tad
>> excessive to have one function *per* trigger table.
>
> Surely, removing the internal name's dependency on the istrigger flag is
> wrong.  If you're going to maintain separate hash entries at the pltcl
> level, why would you want to risk collisions underneath that?

Good catch.  I was basing it off plperl which uses the same proname
for both (sprintf(subname, %s__%u", prodesc->proname, fn_oid)).  Its
OK for plperl because when we compile we save a reference to it and
use that directly (more or less).  The name does not really matter.

Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [PATCH] Custom code int(32|64) => text conversions out of performance reasons
Next
From: Andres Freund
Date:
Subject: Re: [PATCH] Custom code int(32|64) => text conversions out of performance reasons