Re: why does plperl cache functions using just a bool for is_trigger - Mailing list pgsql-hackers

From Tom Lane
Subject Re: why does plperl cache functions using just a bool for is_trigger
Date
Msg-id 8029.1288801722@sss.pgh.pa.us
Whole thread Raw
In response to Re: why does plperl cache functions using just a bool for is_trigger  (Alex Hunsaker <badalex@gmail.com>)
Responses Re: why does plperl cache functions using just a bool for is_trigger
List pgsql-hackers
Alex Hunsaker <badalex@gmail.com> writes:
> On Mon, Nov 1, 2010 at 16:59, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Surely, removing the internal name's dependency on the istrigger flag is
>> wrong.  If you're going to maintain separate hash entries at the pltcl
>> level, why would you want to risk collisions underneath that?

> Good catch.  I was basing it off plperl which uses the same proname
> for both (sprintf(subname, %s__%u", prodesc->proname, fn_oid)).  Its
> OK for plperl because when we compile we save a reference to it and
> use that directly (more or less).  The name does not really matter.

OK, applied.

I notice that plpython is also using the trigger relation's OID, but I
don't know that language well enough to tell whether it really needs to.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Dimitri Fontaine
Date:
Subject: Re: ALTER OBJECT any_name SET SCHEMA name
Next
From: Alvaro Herrera
Date:
Subject: Fwd: Re: ALTER OBJECT any_name SET SCHEMA name