On 28 Nov 2024, at 19:25, Corey Huinker <corey.huinker@gmail.com> wrote:
LGTM, I didn't scan for omissions but the ones in the patch look right to me. I sort of wish we had a shorter macro as CppAsString2() get's pretty verbose when used frequently like this.
I don't quite understand the etymology of the name (it's some variation on C++'s std::to_string, plus...something), but if I did, I'd probably find the name less icky.
AFAIK, Cpp stands for "C Pre Processor" as it is a preprocessor expansion into
a string, and the 2 is simply because CppAsString2() calls CppAsString(). The
reason for the call is perform macro expansion before converting to string.
I agree that it's not icky, it just get's very verbose as opposed how
translation of strings is done with _(<string>) as an example.
