Re: More CppAsString2() in psql's describe.c - Mailing list pgsql-hackers

From Tom Lane
Subject Re: More CppAsString2() in psql's describe.c
Date
Msg-id 390757.1732841494@sss.pgh.pa.us
Whole thread Raw
In response to Re: More CppAsString2() in psql's describe.c  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
Daniel Gustafsson <daniel@yesql.se> writes:
> On 28 Nov 2024, at 19:25, Corey Huinker <corey.huinker@gmail.com> wrote:
>>> I sort of wish we had a shorter macro as CppAsString2() get's pretty verbose
>>> when used frequently like this.

>> I don't quite understand the etymology of the name (it's some variation on C++'s std::to_string, plus...something),
butif I did, I'd probably find the name less icky. 

> AFAIK, Cpp stands for "C Pre Processor" as it is a preprocessor expansion into
> a string, and the 2 is simply because CppAsString2() calls CppAsString().  The
> reason for the call is perform macro expansion before converting to string.

Yeah.  That name was fine when there were just a few occurrences,
but now it seems we've got hundreds, so +1 for something shorter.

I don't like suggestions as generic as STR() though; that's not very
meaningful and also seems like it might collide with some other usage.
How about something like SYM2LIT ("symbol to literal") or SYM2STR?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Jim Jones
Date:
Subject: Re: Truncate logs by max_log_size
Next
From: Matthias van de Meent
Date:
Subject: Re: Changing shared_buffers without restart