Postgres Pro
Downloads
Home   >   mailing lists

Re: removing unnecessary get_att*() lsyscache functions - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: removing unnecessary get_att*() lsyscache functions
Date
Msg-id 9d140f47-1339-00cd-0bc2-3e4418c37253@2ndquadrant.com
Whole thread Raw
In response to Re: removing unnecessary get_att*() lsyscache functions  (Michael Paquier <michael@paquier.xyz>)
Responses Re: removing unnecessary get_att*() lsyscache functions  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
Tree view 
On 19/10/2018 16:00, Michael Paquier wrote:
>> -     if (get_attidentity(RelationGetRelid(rel), attnum))
>> +     if (TupleDescAttr(RelationGetDescr(rel), attnum - 1)->attidentity)
> I find this style heavy, saving Form_pg_attribute into a different
> variable would be more readable in my opinion..

OK, slightly reworked version attached.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment

pgsql-hackers by date:

Previous
From: Alexey Kondratov
Date:
Subject: Re: [Patch] pg_rewind: options to use restore_command fromrecovery.conf or command line
Next
From: Alvaro Herrera
Date:
Subject: Re: [Patch] pg_rewind: options to use restore_command fromrecovery.conf or command line