Re: DBT-3 with SF=20 got failed - Mailing list pgsql-hackers

From Kouhei Kaigai
Subject Re: DBT-3 with SF=20 got failed
Date
Msg-id 9A28C8860F777E439AA12E8AEA7694F8011403FD@BPXM15GP.gisp.nec.co.jp
Whole thread Raw
In response to Re: DBT-3 with SF=20 got failed  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
Responses Re: DBT-3 with SF=20 got failed  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
> Hello KaiGai-san,
> 
> I've discovered a bug in the proposed patch - when resetting the hash
> table after the first batch, it does this:
> 
> memset(hashtable->buckets, 0, sizeof(nbuckets * sizeof(HashJoinTuple)));
> 
> The first 'sizeof' is bogus, so this only zeroes the first 8 bytes of
> the array (usually resulting in crashes due to invalid pointers).
> 
> I fixed it to
> 
>    memset(hashtable->buckets, 0, nbuckets * sizeof(HashJoinTuple));
> 
> Fixed patch attached (marked as v2).
>
Thanks, it was my bug, but oversight.

I want committer to push this fix.
--
NEC Business Creation Division / PG-Strom Project
KaiGai Kohei <kaigai@ak.jp.nec.com>


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: proposal: function parse_ident
Next
From: Kevin Grittner
Date:
Subject: Re: Small patch to fix an O(N^2) problem in foreign keys