Re: nodes/*funcs.c inconsistencies - Mailing list pgsql-hackers

From Kouhei Kaigai
Subject Re: nodes/*funcs.c inconsistencies
Date
Msg-id 9A28C8860F777E439AA12E8AEA7694F801121CE2@BPXM15GP.gisp.nec.co.jp
Whole thread Raw
In response to Re: nodes/*funcs.c inconsistencies  (Noah Misch <noah@leadboat.com>)
Responses Re: nodes/*funcs.c inconsistencies  (Noah Misch <noah@leadboat.com>)
List pgsql-hackers
> On Mon, Apr 16, 2012 at 06:25:15AM -0400, Noah Misch wrote:
> > I observed these inconsistencies in node support functions:
>
> A fresh audit found the attached problems new in 9.5[1].  Most are cosmetic
> INT/UINT or field order corrections.  The non-cosmetic changes involve
> CustomPath, CustomScan, and CreatePolicyStmt.  Feature committers, if the
> existing treatments (ignore custom_plans/custom_paths fields; copy/compare
> "cmd" string pointer as a scalar) were deliberate, please let me know.
>
Thanks for your works.

I also noticed one other inconsistent point; _outMergeJoin() dumps
mergeNullsFirst[] array but it does not use booltostr() macro.

Best regards,
--
NEC Business Creation Division / PG-Strom Project
KaiGai Kohei <kaigai@ak.jp.nec.com>




pgsql-hackers by date:

Previous
From: Andreas Karlsson
Date:
Subject: Re: patch : Allow toast tables to be moved to a different tablespace
Next
From: Michael Paquier
Date:
Subject: Re: Explanation for intermittent buildfarm pg_upgradecheck failures