2010/2/18 Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>:
> Magnus Hagander wrote:
>> There are of course people out
>> there with patches *already* that will have problems with this, but
>> they'll have the problem eventually anyway. The only real stopper
>> there is if someone (Simon would be the most likelyi I guess?) has a
>> big fixup change queued up or so - but if someone does, we can just
>> postpone until right after that one...
>
> It's worth noting that any patches that bit-rot because of pgindent run
> can be fixed with the following procedure:
>
> 1. check out the source tree just before pgindent.
> 2. Apply patch
> 3. Run pgindent
> 4. Diff against source tree just after pgindent.
Doesn't that require that all pgindent runs produce the same output?
Which they generally don't due to different sets of typedefs and
stuff? It's a solvable problem of course, but not quite as simple as
you make it sound :-)
-- Magnus HaganderMe: http://www.hagander.net/Work: http://www.redpill-linpro.com/
