Re: A thought: should we run pgindent now? - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: A thought: should we run pgindent now?
Date
Msg-id 4B7D1491.5060609@enterprisedb.com
Whole thread Raw
In response to Re: A thought: should we run pgindent now?  (Magnus Hagander <magnus@hagander.net>)
Responses Re: A thought: should we run pgindent now?
List pgsql-hackers
Magnus Hagander wrote:
> 2010/2/18 Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>:
>> It's worth noting that any patches that bit-rot because of pgindent run
>>  can be fixed with the following procedure:
>>
>> 1. check out the source tree just before pgindent.
>> 2. Apply patch
>> 3. Run pgindent
>> 4. Diff against source tree just after pgindent.
> 
> Doesn't that require that all pgindent runs produce the same output?
> Which they generally don't due to different sets of typedefs and
> stuff? It's a solvable problem of course, but not quite as simple as
> you make it sound :-)

True. So everyone will have to send their patches to Bruce for bit-rot
fixing ;-)

--  Heikki Linnakangas EnterpriseDB   http://www.enterprisedb.com


pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: A thought: should we run pgindent now?
Next
From: Fujii Masao
Date:
Subject: Re: Streaming replication and unfit messages