Re: float4/float8/int64 passed by value with tsearch fixup - Mailing list pgsql-patches

From Tom Lane
Subject Re: float4/float8/int64 passed by value with tsearch fixup
Date
Msg-id 9738.1208737699@sss.pgh.pa.us
Whole thread Raw
In response to float4/float8/int64 passed by value with tsearch fixup  (Zoltan Boszormenyi <zb@cybertec.at>)
Responses Re: float4/float8/int64 passed by value with tsearch fixup  ("Guillaume Smet" <guillaume.smet@gmail.com>)
List pgsql-patches
Zoltan Boszormenyi <zb@cybertec.at> writes:
> I tried to split the previous patch up to see where the tsearch regression
> comes from. So, it turned out that:
> - float4 conversion is risk free (patch #1)
> - float8 conversion is okay, too, if coupled with time[stamp[tz]] conversion
>      (patch #2) but with int64 timestamps enabled, the next one is also
> needed:
> - int64 conversion (patch #3) is mostly okay but it is the one that's
> causing
>   the tsearch regression

Applied with revisions --- mostly, supporting configure-time control
over whether pass-by-value is used.

            regards, tom lane

pgsql-patches by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Coding standards
Next
From: Tom Lane
Date:
Subject: Re: int8/float8/time/timestamp[tz]/float4 passed by value, was Re: Fix HAVE_LONG[_LONG]_INT_64 to really define to 1