Re: Amcheck: do rightlink verification with lock coupling - Mailing list pgsql-hackers

From Andrey M. Borodin
Subject Re: Amcheck: do rightlink verification with lock coupling
Date
Msg-id 9737FA95-7D97-49D4-AB5A-911A4EAA7A4D@yandex-team.ru
Whole thread Raw
In response to Re: Amcheck: do rightlink verification with lock coupling  (Peter Geoghegan <pg@bowt.ie>)
Responses Re: Amcheck: do rightlink verification with lock coupling
List pgsql-hackers

> 4 авг. 2020 г., в 03:44, Peter Geoghegan <pg@bowt.ie> написал(а):
>
> On Mon, Jul 20, 2020 at 11:46 AM Andrey M. Borodin <x4mmm@yandex-team.ru> wrote:
>> In this thread [0] we decided that lock coupling is necessary for btree_xlog_unlink_page().
>> So, maybe let's revive this patch?
>
> Yes, let's do that. Can you resubmit it, please?

PFA v3.
Changes: fixed few typos in comments.

BTW, reviewing this patch again I cannot understand why we verify link coherence only on leaf level but not for
internalpages? 
I do not see any actual problems here.

Corruption detection power of leftlink-rightlinks on internal pages is diminishingly small compared to leaf pages. But
thereseems to be no reason to exclude internal pages? 

Thanks!

Best regards, Andrey Borodin.

Attachment

pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: Parallel copy
Next
From: Robert Haas
Date:
Subject: Re: new heapcheck contrib module