Re: Remove warning about const qualifier - Mailing list pgsql-patches

From Tom Lane
Subject Re: Remove warning about const qualifier
Date
Msg-id 9702.1176750578@sss.pgh.pa.us
Whole thread Raw
In response to Re: Remove warning about const qualifier  (Kris Jurka <books@ejurka.com>)
List pgsql-patches
Kris Jurka <books@ejurka.com> writes:
> I was testing a gcc 4.3 snapshot from 3/26/07.  It also complains
> hba.c:1199: warning: array subscript is below array bounds
> Which looks pretty bogus to me.

I agree.

> And then the following which may be
> valid, but wasn't something I was concerned about at this time.

> tuplesort.c: In function 'comparetup_heap':
> tuplesort.c:2124: warning: inlining failed in call to 'myFunctionCall2':
> --param large-stack-frame-growth limit reached
> tuplesort.c:2175: warning: called from here

We've got -Winline turned on mainly as a means of finding out whether
inlining happens or not.  I think it's OK to ignore this unless it
happens all over the place.

            regards, tom lane

pgsql-patches by date:

Previous
From: Kris Jurka
Date:
Subject: Re: Remove warning about const qualifier
Next
From: Stefan Huehner
Date:
Subject: Re: Remove warning about const qualifier