Postgres Pro
Downloads
Home   >   mailing lists

Re: Suspicious strcmp() in src/backend/parser/parse_expr.c - Mailing list pgsql-bugs

From Tom Lane
Subject Re: Suspicious strcmp() in src/backend/parser/parse_expr.c
Date
Msg-id 9612.1554991926@sss.pgh.pa.us
Whole thread Raw
In response to Re: Suspicious strcmp() in src/backend/parser/parse_expr.c  (David Rowley <david.rowley@2ndquadrant.com>)
Responses Re: Suspicious strcmp() in src/backend/parser/parse_expr.c
List pgsql-bugs
Tree view 
David Rowley <david.rowley@2ndquadrant.com> writes:
> formatting.c in NUM_prepare_locale()

> else if (strcmp(Np->decimal, ",") !=0)

I'll bet a nickel that that's pgindent's fault.  It probably thinks
that "decimal" is a typedef (greps typedefs.list ... yes), and that
tends to result in funny space-omissions later in the line.

            regards, tom lane

pgsql-bugs by date:

Previous
From: David Rowley
Date:
Subject: Re: Suspicious strcmp() in src/backend/parser/parse_expr.c
Next
From: Christopher Browne
Date:
Subject: Re: List of issues with 4.5 that need to be fixed