Postgres Pro
Downloads
Home   >   mailing lists

Re: Suspicious strcmp() in src/backend/parser/parse_expr.c - Mailing list pgsql-bugs

From Michael Paquier
Subject Re: Suspicious strcmp() in src/backend/parser/parse_expr.c
Date
Msg-id 20190412005857.GA2144@paquier.xyz
Whole thread Raw
In response to Re: Suspicious strcmp() in src/backend/parser/parse_expr.c  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-bugs
Tree view 
On Thu, Apr 11, 2019 at 10:12:06AM -0400, Tom Lane wrote:
> I'll bet a nickel that that's pgindent's fault.  It probably thinks
> that "decimal" is a typedef (greps typedefs.list ... yes), and that
> tends to result in funny space-omissions later in the line.

Yes, I can see as well that pgindent complains here.  As that would
result in more noise on follow-up pgindent runs, I am not changing
this one.
--
Michael
Attachment

pgsql-bugs by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: List of issues with 4.5 that need to be fixed
Next
From: Michael Paquier
Date:
Subject: Re: Suspicious strcmp() in src/backend/parser/parse_expr.c