Re: [HACKERS] Oddity in error handling of constraint violation inExecConstraints for partitioned tables - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: [HACKERS] Oddity in error handling of constraint violation inExecConstraints for partitioned tables
Date
Msg-id 93ba6de4-5669-5111-99ac-d7b6dcefb847@lab.ntt.co.jp
Whole thread Raw
In response to Re: [HACKERS] Oddity in error handling of constraint violation inExecConstraints for partitioned tables  (Amit Khandekar <amitdkhan.pg@gmail.com>)
Responses Re: [HACKERS] Oddity in error handling of constraint violation inExecConstraints for partitioned tables
List pgsql-hackers
On 2017/07/24 16:16, Amit Khandekar wrote:
> On 24 July 2017 at 12:11, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp> wrote:
>> Attached is the updated version of your patch.

Good catch, Amit K. and Amit L.!

> Now that this is done, any particular reason it is not done in
> ExecPartitionCheck() ? I see that there is a do_convert_tuple() in
> that function, again without changing the slot descriptor.

Yeah, I think we would need that in ExecPartitionCheck() as well.

Best regards,
Etsuro Fujita




pgsql-hackers by date:

Previous
From: Amit Khandekar
Date:
Subject: Re: [HACKERS] Oddity in error handling of constraint violation inExecConstraints for partitioned tables
Next
From: Sokolov Yura
Date:
Subject: Re: [HACKERS] Increase Vacuum ring buffer.