Re: Second l10n patch - Mailing list pgadmin-hackers

From Dave Page
Subject Re: Second l10n patch
Date
Msg-id 937d27e10908030404q2e67e375ycc9ad3415e440ebf@mail.gmail.com
Whole thread Raw
In response to Re: Second l10n patch  (Guillaume Lelarge <guillaume@lelarge.info>)
Responses Re: Second l10n patch
List pgadmin-hackers
2009/8/3 Guillaume Lelarge <guillaume@lelarge.info>:
> Le lundi 3 août 2009 à 12:33:56, Guillaume Lelarge a écrit :
>> Le lundi 3 août 2009 à 11:57:02, Dave Page a écrit :
>> > 2009/8/1 Marek Černocký <marek@manet.cz>:
>> > > Hi,
>> > >
>> > > I send patch. It solves translation for object type names in reports.
>> >
>> > Should code like this use wxPLURAL?
>> >
>> > int section = report->XmlCreateSection(wxString::Format(_("%s
>> > dependents"), object->GetTranslatedTypeName().c_str()));
>>
>> No. We need wxPLURAL when we have a variable that tells us if it is plural
>> or not. In this code, there's nothing that gives us a hint about it.
>>
>> Note that I didn't actually try this patch. Only read it.
>
> Just tried it, and it works the way I think it should. I can commit it if you
> want.

Sure - thanks.


--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com

pgadmin-hackers by date:

Previous
From: Guillaume Lelarge
Date:
Subject: Re: Second l10n patch
Next
From: Guillaume Lelarge
Date:
Subject: Re: Change: l10n patch