Re: Second l10n patch - Mailing list pgadmin-hackers

From Guillaume Lelarge
Subject Re: Second l10n patch
Date
Msg-id 200908031319.14446.guillaume@lelarge.info
Whole thread Raw
In response to Re: Second l10n patch  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
Le lundi 3 août 2009 à 13:04:34, Dave Page a écrit :
> 2009/8/3 Guillaume Lelarge <guillaume@lelarge.info>:
> > Le lundi 3 août 2009 à 12:33:56, Guillaume Lelarge a écrit :
> >> Le lundi 3 août 2009 à 11:57:02, Dave Page a écrit :
> >> > 2009/8/1 Marek Černocký <marek@manet.cz>:
> >> > > Hi,
> >> > >
> >> > > I send patch. It solves translation for object type names in
> >> > > reports.
> >> >
> >> > Should code like this use wxPLURAL?
> >> >
> >> > int section = report->XmlCreateSection(wxString::Format(_("%s
> >> > dependents"), object->GetTranslatedTypeName().c_str()));
> >>
> >> No. We need wxPLURAL when we have a variable that tells us if it is
> >> plural or not. In this code, there's nothing that gives us a hint about
> >> it.
> >>
> >> Note that I didn't actually try this patch. Only read it.
> >
> > Just tried it, and it works the way I think it should. I can commit it if
> > you want.
>
> Sure - thanks.

Done. Sorry for the two commits, I forgot the CHANGELOG file.


--
Guillaume.
 http://www.postgresqlfr.org
 http://dalibo.com

pgadmin-hackers by date:

Previous
From: svn@pgadmin.org
Date:
Subject: SVN Commit by guillaume: r7999 - trunk/pgadmin3
Next
From: Dave Page
Date:
Subject: Re: Change: l10n patch