Re: Bug in 9.0Alpha4 - Mailing list pgsql-hackers

From Gokulakannan Somasundaram
Subject Re: Bug in 9.0Alpha4
Date
Msg-id 9362e74e1003160913w2a3b0c4co163aa2a0435076bc@mail.gmail.com
Whole thread Raw
In response to Re: Bug in 9.0Alpha4  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Bug in 9.0Alpha4
List pgsql-hackers


transformSortClause is passed the untransformed aggorder list, which is
in fact a list of SortBy nodes, and it returns the transformed list
(SortGroupClause nodes), which is stored back into the aggorder field
a bit further down.

There are a number of regression tests that would fail in obvious ways
if this code didn't work.

Right Tom.  I got confused, because the comment at Aggref struct definition told that it is a list of SortGroupClause. May be you can update your comments there.

Thanks,
Gokul.

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Bug in 9.0Alpha4
Next
From: Pavel Stehule
Date:
Subject: parametrized NOTIFY - issue in plpgsql, maybe ToDo