Re: Add column name to error description - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Add column name to error description
Date
Msg-id 936268.1741316738@sss.pgh.pa.us
Whole thread Raw
In response to Re: Add column name to error description  (Erik Wienhold <ewie@ewie.name>)
Responses Re: Add column name to error description
Re: Add column name to error description
List pgsql-hackers
Erik Wienhold <ewie@ewie.name> writes:
> But I don't see the point in keeping variables atttypid and atttypmod
> around when those values are now available via outatt.  Removing these
> two variables makes the code easier to read IMO.  Done so in the
> attached v4.

I think the idea of the original coding was to keep those values in
registers in the inner loop rather than re-fetching them each time.
But that's probably an unmeasurably microscopic optimization, if
real at all (modern compilers might figure it out for themselves).
Do others agree Erik's version improves readability?

            regards, tom lane



pgsql-hackers by date:

Previous
From: Corey Huinker
Date:
Subject: Re: Statistics Import and Export
Next
From: Tom Lane
Date:
Subject: Re: Commitfest app release on Feb 17 with many improvements