Re: Add column name to error description - Mailing list pgsql-hackers

From Erik Wienhold
Subject Re: Add column name to error description
Date
Msg-id 45bdc699-5606-4a00-86d7-46ca42d5ad4a@ewie.name
Whole thread Raw
In response to Re: Add column name to error description  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Add column name to error description
List pgsql-hackers
On 2025-03-07 04:05 +0100, Tom Lane wrote:
> Erik Wienhold <ewie@ewie.name> writes:
> > But I don't see the point in keeping variables atttypid and atttypmod
> > around when those values are now available via outatt.  Removing these
> > two variables makes the code easier to read IMO.  Done so in the
> > attached v4.
> 
> I think the idea of the original coding was to keep those values in
> registers in the inner loop rather than re-fetching them each time.

Could be.  But the main reason was to hold the output column type as the
inner loop repurposed att for the input column.  With the separate
outatt and inatt this is no longer necessary.

-- 
Erik Wienhold



pgsql-hackers by date:

Previous
From: "Chiranmoy.Bhattacharya@fujitsu.com"
Date:
Subject: Re: [PATCH] SVE popcount support
Next
From: jian he
Date:
Subject: Re: Change COPY ... ON_ERROR ignore to ON_ERROR ignore_row