Re: pg_proc.h - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_proc.h
Date
Msg-id 9222.1131637085@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_proc.h  ("Dave Page" <dpage@vale-housing.co.uk>)
List pgsql-hackers
"Dave Page" <dpage@vale-housing.co.uk> writes:
> I vote for fixing the file (but then I'm not doing the work).
> Unused_oids or whatevers it's called is fine, but it's still handy to be
> able to read the file easily.

Our convention is that hand-assigned OIDs are *globally* unique,
not just within the particular catalog.  This means you *must* use
unused_oids to find a free OID; eyeballing the catalog listing isn't
enough, even if it were in strict order.

Given that, I think "readability" really consists in keeping related
functions together.  If we were going to do any wholesale reordering,
I'd want to see it done with an eye to sorting the functions into
logical groups, not a blind numeric sort.
        regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_proc.h
Next
From: Martijn van Oosterhout
Date:
Subject: Re: win32 8.1 pgadmin dll issues