Re: pgwin32_open returning EINVAL - Mailing list pgsql-hackers

From Trevor Talbot
Subject Re: pgwin32_open returning EINVAL
Date
Msg-id 90bce5730712200439i40629f9fq622089cc304ca838@mail.gmail.com
Whole thread Raw
In response to Re: pgwin32_open returning EINVAL  (Magnus Hagander <magnus@hagander.net>)
Responses Re: pgwin32_open returning EINVAL  (Magnus Hagander <magnus@hagander.net>)
Re: pgwin32_open returning EINVAL  (Alvaro Herrera <alvherre@commandprompt.com>)
Re: pgwin32_open returning EINVAL  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On 12/20/07, Magnus Hagander <magnus@hagander.net> wrote:

> ereport(WARNING,
>     (errmsg("could not open file \"%s\": %s violation", fileName,
>           (GetLastError() ==
> ERROR_SHARING_VIOLATION)?_("sharing"):_("lock")),
>          errdetail("Continuing to retry for 30 seconds."),
>          errhint("You may have antivirus, backup or similar software
> interfering with the database.")));

Without looking myself, is it possible for errhint() or errdetail() to
do something that affects GetLastError()? It's like errno, checking it
very far away from the call site makes me nervous.


pgsql-hackers by date:

Previous
From: Martijn van Oosterhout
Date:
Subject: Re: Sorting Improvements for 8.4
Next
From: Magnus Hagander
Date:
Subject: Re: pgwin32_open returning EINVAL