Re: `make check` doesn't pass on MacOS Catalina - Mailing list pgsql-hackers

From Tom Lane
Subject Re: `make check` doesn't pass on MacOS Catalina
Date
Msg-id 9096.1659796869@sss.pgh.pa.us
Whole thread Raw
In response to Re: `make check` doesn't pass on MacOS Catalina  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
> On 2022-08-06 Sa 06:49, Gurjeet Singh wrote:
>> There are no comments as to why one should choose to use --delay-check
>> ($delay_check). This email, and the pointer to the paragraph buried in
>> the docs, shared by Tom, are the only two ways one can understand what
>> is causing this failure, and how to get around it.

> In general we want to run "make check" as soon as possible after running
> "make" on the core code. That's why I didn't simply delay it
> unconditionally.

In general --- that is, on non-broken platforms --- "make check"
*should* work without a prior "make install".  I am absolutely
not in favor of changing the buildfarm so that it fails to detect
the problem if we break that.  But for sure it'd make sense to add
some comments to the wiki and/or sample config file explaining
that you need to set this option on systems X,Y,Z.

On macOS you need to use it if you haven't disabled SIP.
I don't have the details about any other problem platforms.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Zhang Mingli
Date:
Subject: Re: Allocator sizeof operand mismatch (src/backend/regex/regcomp.c)
Next
From: Tom Lane
Date:
Subject: Re: Allocator sizeof operand mismatch (src/backend/regex/regcomp.c)