Re: Allocator sizeof operand mismatch (src/backend/regex/regcomp.c) - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Allocator sizeof operand mismatch (src/backend/regex/regcomp.c)
Date
Msg-id 9352.1659797245@sss.pgh.pa.us
Whole thread Raw
In response to Re: Allocator sizeof operand mismatch (src/backend/regex/regcomp.c)  (Zhang Mingli <zmlpostgres@gmail.com>)
Responses Re: Allocator sizeof operand mismatch (src/backend/regex/regcomp.c)
List pgsql-hackers
Zhang Mingli <zmlpostgres@gmail.com> writes:
> I think it’s ok, re_guts is converted when  used
> (struct guts *) re->re_guts;
> And there is comments in regex.h
>     char *re_guts; /* `char *' is more portable than `void *' */

Boy, that comment is showing its age isn't it?  If we were to do
anything about this, I'd be more inclined to change re_guts to void*.
But, never having seen any compiler warnings about this code,
I don't feel a strong need to do something.

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: `make check` doesn't pass on MacOS Catalina
Next
From: Joe Conway
Date:
Subject: Re: [PATCH] Expose port->authn_id to extensions and triggers