Re: Allocator sizeof operand mismatch (src/backend/regex/regcomp.c) - Mailing list pgsql-hackers

From Zhang Mingli
Subject Re: Allocator sizeof operand mismatch (src/backend/regex/regcomp.c)
Date
Msg-id a7a237de-a881-4635-9d0f-bd5466e38d4d@Spark
Whole thread Raw
In response to Re: Allocator sizeof operand mismatch (src/backend/regex/regcomp.c)  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Aug 6, 2022, 22:47 +0800, Tom Lane <tgl@sss.pgh.pa.us>, wrote:
Zhang Mingli <zmlpostgres@gmail.com> writes:
I think it’s ok, re_guts is converted when  used
(struct guts *) re->re_guts;
And there is comments in regex.h
char *re_guts; /* `char *' is more portable than `void *' */

Boy, that comment is showing its age isn't it? If we were to do
anything about this, I'd be more inclined to change re_guts to void*.
Got it , thanks.

pgsql-hackers by date:

Previous
From: Joe Conway
Date:
Subject: Re: [PATCH] Expose port->authn_id to extensions and triggers
Next
From: Tom Lane
Date:
Subject: Re: `make check` doesn't pass on MacOS Catalina