Re: pgsql-server/src/timezone pgtz.h - Mailing list pgsql-committers

From Tom Lane
Subject Re: pgsql-server/src/timezone pgtz.h
Date
Msg-id 9036.1083375288@sss.pgh.pa.us
Whole thread Raw
In response to pgsql-server/src/timezone pgtz.h  (momjian@svr1.postgresql.org (Bruce Momjian))
Responses Re: pgsql-server/src/timezone pgtz.h
List pgsql-committers
momjian@svr1.postgresql.org (Bruce Momjian) writes:
>     Timezone code checks for HAVE_SYMLINK of zero, so use in pgtz.h:

>     #ifndef HAVE_SYMLINK
>     #define HAVE_SYMLINK 0
>     #endif

Surely this is exactly the wrong thing to do.  It will break code that
tests for #ifdef HAVE_SYMLINK.  Shouldn't you instead fix the timezone
library to make its tests in a more standard way?

            regards, tom lane

pgsql-committers by date:

Previous
From: momjian@svr1.postgresql.org (Bruce Momjian)
Date:
Subject: pgsql-server/src/timezone pgtz.c pgtz.h
Next
From: Bruce Momjian
Date:
Subject: Re: pgsql-server/src/timezone pgtz.h