Re: pgsql-server/src/timezone pgtz.h - Mailing list pgsql-committers

Tom Lane wrote:
> momjian@svr1.postgresql.org (Bruce Momjian) writes:
> >     Timezone code checks for HAVE_SYMLINK of zero, so use in pgtz.h:
>
> >     #ifndef HAVE_SYMLINK
> >     #define HAVE_SYMLINK 0
> >     #endif
>
> Surely this is exactly the wrong thing to do.  It will break code that
> tests for #ifdef HAVE_SYMLINK.  Shouldn't you instead fix the timezone
> library to make its tests in a more standard way?

I thought about that but I figured the less we change the tz library,
the easier it will be to replace later.  The code uses a zero test
rather than an undef test, and that seemed OK to me assuming we will not
be mucking with this code at all.

--
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073