Re: New option for pg_basebackup, to specify a different directory for pg_xlog - Mailing list pgsql-hackers

From Haribabu kommi
Subject Re: New option for pg_basebackup, to specify a different directory for pg_xlog
Date
Msg-id 8977CB36860C5843884E0A18D8747B0372BEF110@szxeml558-mbs.china.huawei.com
Whole thread
In response to Re: New option for pg_basebackup, to specify a different directory for pg_xlog  (Gavin Flower <GavinFlower@archidevsys.co.nz>)
List pgsql-hackers

on 20 November 2013 23:44 Gavin Flower wrote:

>On 20/11/13 23:43, Haribabu kommi wrote:

>>I tried using of stat'ing in two directories, which is having a problem in windows.
>>So modified old approach to detect limited errors. Updated patch attached. 
>>This will detect and throw an error in the following scenarios.
>>1. pg_basebackup -D /home/data --xlogdir=/home/data
>>2. pg_basebackup -D data --xlogdir=/home/data -- home is the CWD
>>3. pg_basebackup -D ../data --xlogdir=/data -- home is the CWD
 

>I don't think Postgres on other systems should be hobbled by the limitations of Microsoft software!
>If certain features of Postgres are either not available, or are available in a reduced form on Microsoft platforms, then this should be documented - might provide subtle hints to upgrade to Linux.

 

The patch which sent in earlier mail provides the detection of base and xlog directories are same or not

In both windows and linux with a different way of identifying the same without stat’ing.

If other also agrees to add stat’ing then I will change the patch accordingly and document the behavior

Change for windows.

 

Regards,

Hari babu.

 

pgsql-hackers by date:

Previous
From: Amit Khandekar
Date:
Subject: Re: COPY table FROM STDIN doesn't show count tag
Next
From: Pavel Stehule
Date:
Subject: new unicode table border styles for psql