Postgres Pro
Downloads
Home   >   mailing lists

Re: Two aesthetic bugs in the 1-byte packed varlena code - Mailing list pgsql-patches

From Gregory Stark
Subject Re: Two aesthetic bugs in the 1-byte packed varlena code
Date
Msg-id 87wsy9fe8h.fsf@oxford.xeocode.com
Whole thread Raw
In response to Re: Two aesthetic bugs in the 1-byte packed varlena code  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Two aesthetic bugs in the 1-byte packed varlena code  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
Tree view 
"Tom Lane" <tgl@sss.pgh.pa.us> writes:

> Gregory Stark <stark@enterprisedb.com> writes:
>> Why do we even have those fields in the structs if they're unsafe to use?
>
> 1. genbki.sh

But genbki.sh wouldn't care if we #if 0 around the unsafe ones would it?

> 2. As you note, they're not always unsafe to use.

Well, it seems like it would be nice to mark which ones are and aren't unsafe
rather than have them all be there waiting to trip people up.

--
  Gregory Stark
  EnterpriseDB          http://www.enterprisedb.com

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Two aesthetic bugs in the 1-byte packed varlena code
Next
From: Satoshi Nagayasu
Date:
Subject: trace_checkpoint parameter patch