Re: [sqlsmith] Crash on GUC serialization - Mailing list pgsql-hackers

From Andreas Seltenreich
Subject Re: [sqlsmith] Crash on GUC serialization
Date
Msg-id 87oa1b73yf.fsf@credativ.de
Whole thread Raw
In response to Re: [sqlsmith] Crash on GUC serialization  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [sqlsmith] Crash on GUC serialization
List pgsql-hackers
Michael Paquier writes:

> [2. text/plain; fix-guc-string-eval.patch]

I'm afraid taking care of the length computation is not sufficient.
ISTM like it'll still try to serialize the NULL pointer later on in
serialize_variable:

,----[ guc.c:9108 ]
| case PGC_STRING:
|     {
|     struct config_string *conf = (struct config_string *) gconf;
|     do_serialize(destptr, maxbytes, "%s", *conf->variable);
`----



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [sqlsmith] Crash on GUC serialization
Next
From: Gilles Darold
Date:
Subject: Re: Patch to implement pg_current_logfile() function