Re: [sqlsmith] Crash on GUC serialization - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [sqlsmith] Crash on GUC serialization
Date
Msg-id CAB7nPqRdpG_WuVTwpp6=b0wEDPki7hPX+iLwKf9e4Q-iEj0APQ@mail.gmail.com
Whole thread Raw
In response to Re: [sqlsmith] Crash on GUC serialization  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [sqlsmith] Crash on GUC serialization  (Andreas Seltenreich <seltenreich@gmx.de>)
Re: [sqlsmith] Crash on GUC serialization  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sat, Nov 19, 2016 at 9:31 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Andreas Seltenreich <seltenreich@gmx.de> writes:
>> sqlsmith just made a GUC that tricks the serialization code into
>> dereferencing a nullpointer.  Here's a recipe:
>
> Thanks for the report!  Looks like the serialization code has overlooked
> the fact that string-valued GUCs can be NULL.  Surprising we didn't
> find that before ...

I was half-way through it when you sent your email. It seems to me
that we need to take care only of the case for PGC_STRING, per the
attached.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: pg_dump -s -b
Next
From: Andreas Seltenreich
Date:
Subject: Re: [sqlsmith] Crash on GUC serialization