Re: pgsql: Add basic TAP tests for psql's tab-completion logic. - Mailing list pgsql-hackers

From ilmari@ilmari.org (Dagfinn Ilmari Mannsåker)
Subject Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
Date
Msg-id 87k16610xk.fsf@wibble.ilmari.org
Whole thread Raw
In response to Re: pgsql: Add basic TAP tests for psql's tab-completion logic.  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Add basic TAP tests for psql's tab-completion logic.  (ilmari@ilmari.org (Dagfinn Ilmari Mannsåker))
Re: pgsql: Add basic TAP tests for psql's tab-completion logic.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
Tom Lane <tgl@sss.pgh.pa.us> writes:

> Cool, I'll go commit a fix along those lines.  Thanks for tracing
> this down!

Here's one final style cleanup for the TAP test.

- use like() for the banner test
- pass the regexes around as qr// objects, so they can be
  syntax-highlighted properly, and don't need regex
  metacharacter-escaping backslashes doubled.
- include the regex that didn't match in the diagnostic

- ilmari
-- 
"The surreality of the universe tends towards a maximum" -- Skud's Law
"Never formulate a law or axiom that you're not prepared to live with
 the consequences of."                              -- Skud's Meta-Law




pgsql-hackers by date:

Previous
From: Vik Fearing
Date:
Subject: Re: WIP: System Versioned Temporal Table
Next
From: ilmari@ilmari.org (Dagfinn Ilmari Mannsåker)
Date:
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.