Re: pgsql: Add basic TAP tests for psql's tab-completion logic. - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
Date
Msg-id 19736.1578242316@sss.pgh.pa.us
Whole thread Raw
In response to Re: pgsql: Add basic TAP tests for psql's tab-completion logic.  (ilmari@ilmari.org (Dagfinn Ilmari Mannsåker))
Responses Re: pgsql: Add basic TAP tests for psql's tab-completion logic.  (Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>)
List pgsql-hackers
ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
> Here's one final style cleanup for the TAP test.

LGTM, pushed.

One minor note: you wanted to change the \DRD test to

+check_completion("\\DRD\t", qr/\\drds /, "complete \\DRD<tab> to \\drds");

but that doesn't work everywhere, unfortunately.  On my machine
what comes out is

# Actual output was "\\DRD\b\b\bdrds "
# Did not match "(?-xism:\\drds )"

            regards, tom lane



pgsql-hackers by date:

Previous
From: Tomas Vondra
Date:
Subject: Re: FETCH FIRST clause WITH TIES option
Next
From: Dagfinn Ilmari Mannsåker
Date:
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.