pg_stat_statements vs. SELECT FOR UPDATE - Mailing list pgsql-hackers

From Andrew Gierth
Subject pg_stat_statements vs. SELECT FOR UPDATE
Date
Msg-id 87h8e4hfwv.fsf@news-spur.riddles.org.uk
Whole thread Raw
Responses Re: pg_stat_statements vs. SELECT FOR UPDATE  (Vik Fearing <vik.fearing@2ndquadrant.com>)
Re: pg_stat_statements vs. SELECT FOR UPDATE  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
pg_stat_statements considers a plain select and a select for update to
be equivalent, which seems quite wrong to me as they will have very
different performance characteristics due to locking.

The only comment about it in the code is:

    /* we ignore rowMarks */

I propose that it should not ignore rowMarks, per the attached patch or
something similar.

(thanks to Vik Fearing for preliminary testing)

-- 
Andrew (irc:RhodiumToad)


Attachment

pgsql-hackers by date:

Previous
From: Andrew Gierth
Date:
Subject: Re: Ryu floating point output patch
Next
From: "Daniel Verite"
Date:
Subject: Re: Alternative to \copy in psql modelled after \g