Re: pg_stat_statements vs. SELECT FOR UPDATE - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_stat_statements vs. SELECT FOR UPDATE
Date
Msg-id 21047.1547917230@sss.pgh.pa.us
Whole thread Raw
In response to pg_stat_statements vs. SELECT FOR UPDATE  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
Responses Re: pg_stat_statements vs. SELECT FOR UPDATE  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
List pgsql-hackers
Andrew Gierth <andrew@tao11.riddles.org.uk> writes:
> I propose that it should not ignore rowMarks, per the attached patch or
> something similar.

+1 for not ignoring rowMarks, but this patch seems like a hack to me.
Why didn't you just add RowMarkClause as one of the known alternative
expression node types?  There's no advantage to hard-wiring such
restrictive assumptions about where it can appear.

            regards, tom lane


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: A small note on the portability of cmake
Next
From: Tom Lane
Date:
Subject: Re: pg_stat_statements vs. SELECT FOR UPDATE