Re: float4/float8/int64 passed by value with tsearchfixup - Mailing list pgsql-patches

From Gregory Stark
Subject Re: float4/float8/int64 passed by value with tsearchfixup
Date
Msg-id 87ej92esr9.fsf@oxford.xeocode.com
Whole thread Raw
In response to Re: float4/float8/int64 passed by value with tsearch fixup  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: float4/float8/int64 passed by value with tsearchfixup  (Tom Lane <tgl@sss.pgh.pa.us>)
Re: float4/float8/int64 passed by value with tsearchfixup  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-patches
"Alvaro Herrera" <alvherre@commandprompt.com> writes:

> Tom Lane wrote:
>
>> Specifically, I think what you missed is that on some platforms C
>> functions pass or return float values differently from similar-sized
>> integer or pointer values (typically, the float values get passed in
>> floating-point registers).
>
> Argh ... I would have certainly missed that.

Hum. That's a valid concern for some platforms, Sparc I think?

But I'm skeptical that it would hit such a wide swathe of the build farm. In
particular AFAIK the standard ABI for i386 does no such thing. You can get
behaviour like that from GCC using function attributes like regparam but it's
not the default.

--
  Gregory Stark
  EnterpriseDB          http://www.enterprisedb.com
  Ask me about EnterpriseDB's Slony Replication support!

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: Testing pg_terminate_backend()
Next
From: Tom Lane
Date:
Subject: Re: float4/float8/int64 passed by value with tsearchfixup