Re: float4/float8/int64 passed by value with tsearchfixup - Mailing list pgsql-patches

From Tom Lane
Subject Re: float4/float8/int64 passed by value with tsearchfixup
Date
Msg-id 24749.1208556084@sss.pgh.pa.us
Whole thread Raw
In response to Re: float4/float8/int64 passed by value with tsearchfixup  (Gregory Stark <stark@enterprisedb.com>)
Responses Re: float4/float8/int64 passed by value with tsearchfixup
Re: float4/float8/int64 passed by value with tsearchfixup
List pgsql-patches
Gregory Stark <stark@enterprisedb.com> writes:
>> Tom Lane wrote:
>>> Specifically, I think what you missed is that on some platforms C
>>> functions pass or return float values differently from similar-sized
>>> integer or pointer values (typically, the float values get passed in
>>> floating-point registers).

> Hum. That's a valid concern for some platforms, Sparc I think?
> But I'm skeptical that it would hit such a wide swathe of the build
> farm.

I was wondering about that too, once it became obvious that (almost?)
everything was failing not just some platforms.  However, this
afternoon's CVS HEAD *does* pass the seg regression test for me on HPPA,
and I presume it passed on whatever Alvaro is using (btw, what was
that?).  So there's definitely a platform dependency involved and not
just you-missed-a-pointer-someplace.

            regards, tom lane

pgsql-patches by date:

Previous
From: Gregory Stark
Date:
Subject: Re: float4/float8/int64 passed by value with tsearchfixup
Next
From: Alvaro Herrera
Date:
Subject: Re: float4/float8/int64 passed by value with tsearchfixup