Re: Patch to fix write after end of array in hashed agg initialization - Mailing list pgsql-hackers

From Andrew Gierth
Subject Re: Patch to fix write after end of array in hashed agg initialization
Date
Msg-id 87d0k9dd4u.fsf@news-spur.riddles.org.uk
Whole thread Raw
In response to Re: Patch to fix write after end of array in hashed agg initialization  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
>>>>> "Tom" == Tom Lane <tgl@sss.pgh.pa.us> writes:

 > Andrew Gierth <andrew@tao11.riddles.org.uk> writes:
 >> My inclination is to fix this in the planner rather than the
 >> executor; there seems no good reason to actually hash a duplicate
 >> column more than once.

 Tom> Sounds reasonable --- but would it make sense to introduce some
 Tom> assertions, or other cheap tests, into the executor to check that
 Tom> it's not being given a case it can't handle?

Oh definitely, I was planning on it.

-- 
Andrew (irc:RhodiumToad)



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Patch to fix write after end of array in hashed agg initialization
Next
From: Michael Paquier
Date:
Subject: Re: nitpick about poor style in MergeAttributes