Postgres Pro
Downloads
Home   >   mailing lists

Re: Patch to fix write after end of array in hashed agg initialization - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Patch to fix write after end of array in hashed agg initialization
Date
Msg-id 16775.1558584156@sss.pgh.pa.us
Whole thread Raw
In response to Re: Patch to fix write after end of array in hashed agg initialization  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
Responses Re: Patch to fix write after end of array in hashed agg initialization  (Andrew Gierth <andrew@tao11.riddles.org.uk>)
List pgsql-hackers
Tree view 
Andrew Gierth <andrew@tao11.riddles.org.uk> writes:
> My inclination is to fix this in the planner rather than the executor;
> there seems no good reason to actually hash a duplicate column more than
> once.

Sounds reasonable --- but would it make sense to introduce some
assertions, or other cheap tests, into the executor to check that
it's not being given a case it can't handle?

            regards, tom lane

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Remove useless associativity/precedence from parsers
Next
From: Andrew Gierth
Date:
Subject: Re: Patch to fix write after end of array in hashed agg initialization