Re: FATAL: bogus data in lock file "postmaster.pid": "" - Mailing list pgsql-hackers

From Tom Lane
Subject Re: FATAL: bogus data in lock file "postmaster.pid": ""
Date
Msg-id 8665.1346185536@sss.pgh.pa.us
Whole thread Raw
In response to Re: FATAL: bogus data in lock file "postmaster.pid": ""  (Bruce Momjian <bruce@momjian.us>)
Responses Re: FATAL: bogus data in lock file "postmaster.pid": ""
List pgsql-hackers
Bruce Momjian <bruce@momjian.us> writes:
> Updated patch attached which just reports the file as empty.  I assume
> we don't want the extra text output for pg_ctl like we do for the
> backend.

The backend side of this looks mostly sane to me (but drop the \n,
messages are not supposed to contain those).  But the feof test proposed
for pg_ctl is no good: consider a file containing just, say, "-".
fscanf would eat the "-", then hit eof, and this would complain the file
is empty.  Possibly checking for ftell(pidf) == 0 would do, though I'm
not sure whether it's portable to assume fscanf would eat a non-numeric
character before complaining.
        regards, tom lane



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_dump incorrect output in plaintext mode
Next
From: Robert Haas
Date:
Subject: Re: MySQL search query is not executing in Postgres DB