Re: pg_dump incorrect output in plaintext mode - Mailing list pgsql-hackers

From Tom Lane
Subject Re: pg_dump incorrect output in plaintext mode
Date
Msg-id 8051.1346183955@sss.pgh.pa.us
Whole thread Raw
In response to Re: pg_dump incorrect output in plaintext mode  (Magnus Hagander <magnus@hagander.net>)
Responses Re: pg_dump incorrect output in plaintext mode
List pgsql-hackers
Magnus Hagander <magnus@hagander.net> writes:
> On Tue, Aug 28, 2012 at 6:42 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I don't see anything particularly incorrect about that.  The point of
>> the --verbose switch is to track what pg_dump is doing, and if what
>> it's doing involves going through RestoreArchive(), why should we try
>> to hide the fact?

> "restoring data for table 't'" makes you think it's actuall restoring
> things. It's not. That dumping is implemented by calling an internal
> function called RestoreArchive() has to be an implementation detail...
> It certainly confuses users that we say "restoring" when we're not
> doing that...

Well, why don't we just s/restoring/processing/ in the debug message,
and call it good?
        regards, tom lane



pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: Audit Logs WAS: temporal support patch
Next
From: Tom Lane
Date:
Subject: Re: FATAL: bogus data in lock file "postmaster.pid": ""