Re: get_progname and .exe suffix - Mailing list pgsql-hackers-win32

From Tom Lane
Subject Re: get_progname and .exe suffix
Date
Msg-id 8650.1097945846@sss.pgh.pa.us
Whole thread Raw
In response to Re: get_progname and .exe suffix  (Andrew Dunstan <andrew@dunslane.net>)
Responses Re: get_progname and .exe suffix  (Andrew Dunstan <andrew@dunslane.net>)
List pgsql-hackers-win32
Andrew Dunstan <andrew@dunslane.net> writes:
> Tom Lane wrote:
>> What would break if we caused get_progname itself to strip the suffix?

> Yes. get_progname() actually just returns a pointer to one past the last
> directory separator it finds in its argument string. Having it strip the
> .exe directly would in effect involve mangling argv[0]. That's what
> makes me slightly nervous about it. We could have it strdup() the result
> and then mangle that - note that it is called by postmaster before we
> set up any memory context stuff.

Seems reasonable.  What I was more worried about though was whether
there are any callers that actually need a non-stripped result.

            regards, tom lane

pgsql-hackers-win32 by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: get_progname and .exe suffix
Next
From: Andrew Dunstan
Date:
Subject: Re: get_progname and .exe suffix