Re: plperl warnings on win32 - Mailing list pgsql-patches

From Tom Lane
Subject Re: plperl warnings on win32
Date
Msg-id 8598.1185285357@sss.pgh.pa.us
Whole thread Raw
In response to plperl warnings on win32  (Magnus Hagander <magnus@hagander.net>)
Responses Re: plperl warnings on win32  (Magnus Hagander <magnus@hagander.net>)
List pgsql-patches
Magnus Hagander <magnus@hagander.net> writes:
>   override CPPFLAGS += -DPLPERL_HAVE_UID_GID
> + # Perl on win32 contains /* within comment all over the header file,
> + # so disable this warning.
> + override CFLAGS += -Wno-comment
>   endif

If you insist you can apply that in some way that makes it Windows-only.
I object strongly to the patch in this form, because it will mask our
own mistakes as well as one particular Perl build's mistakes.

            regards, tom lane

pgsql-patches by date:

Previous
From: Andrew Dunstan
Date:
Subject: Re: plperl warnings on win32
Next
From: Gregory Stark
Date:
Subject: Re: msvc const warnings