Re: plperl warnings on win32 - Mailing list pgsql-patches

From Magnus Hagander
Subject Re: plperl warnings on win32
Date
Msg-id 20070724135915.GG19199@svr2.hagander.net
Whole thread Raw
In response to Re: plperl warnings on win32  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: plperl warnings on win32
Re: plperl warnings on win32
Re: plperl warnings on win32
List pgsql-patches
On Tue, Jul 24, 2007 at 09:55:57AM -0400, Tom Lane wrote:
> Magnus Hagander <magnus@hagander.net> writes:
> >   override CPPFLAGS += -DPLPERL_HAVE_UID_GID
> > + # Perl on win32 contains /* within comment all over the header file,
> > + # so disable this warning.
> > + override CFLAGS += -Wno-comment
> >   endif
>
> If you insist you can apply that in some way that makes it Windows-only.
> I object strongly to the patch in this form, because it will mask our
> own mistakes as well as one particular Perl build's mistakes.

Uh, it's already inside a win32-only block. So it'll only affect mingw.

Do you know of a way to do it from inside gcc, like the #pragma that exists
for win32 to disable specific warnings? If so we could just disable it on
the line before we #include the perl header, and re-enable it after...

//Magnus

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: Async Commit, v21 (now: v22)
Next
From: Greg Smith
Date:
Subject: Re: Async Commit, v21 (now: v22)